Skip to content

Slim precommit image #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Slim precommit image #701

wants to merge 1 commit into from

Conversation

@samzong
Copy link
Contributor

@samzong samzong commented Nov 19, 2025 •
edited
Loading 

- latest             912d04c9f776   3 weeks ago     3.58GB
+ clean-final        6447339bfe93   6 minutes ago   2.75GB

Record some...

image

FILL IN THE PR DESCRIPTION HERE

FIX #693 (link existing issues this PR will resolve)

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

@netlify
Copy link

netlify bot commented Nov 19, 2025 •
edited
Loading

✅ Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit a8a3d62
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/691ed9aecd29c50008cd2d27
😎 Deploy Preview https://deploy-preview-701--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Nov 19, 2025 •
edited
Loading

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 Root Directory

Owners: @rootfs, @Xunzhuo
Files changed:

  • Dockerfile.precommit
vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@rootfs
Copy link
Collaborator

rootfs commented Nov 19, 2025

@yuluo-yx

@samzong samzong force-pushed the slim-precommit-image branch 3 times, most recently from 3640555 to 6b3a340 Compare November 20, 2025 08:46
@samzong
Copy link
Contributor Author

samzong commented Nov 20, 2025

use dive

image

@samzong samzong force-pushed the slim-precommit-image branch from 6b3a340 to a8a3d62 Compare November 20, 2025 09:04
@samzong
Copy link
Contributor Author

samzong commented Nov 20, 2025

@Xunzhuo @rootfs @yuluo-yx

After a while of trying, it's hard to meet my expectations; would like to ask for advice.

I’ve squeezed the pre-commit image from 3.58 GB to 2.75 GB, but any further cuts start breaking Go/Rust checks.

To keep all Go/Rust hooks and still slim meaningfully, the only practical option is to run Go/Rust hooks via separate language: docker_image entries, each pointing to a minimal go (gofmt + golangci-lint) and rust (cargo + rustfmt + toolchain) image. The main pre-commit image would then keep only Python linters + markdownlint + shellcheck.

This should shave off a few size and speed pulls/builds, at the cost of maintaining two small images and slightly more config.

If you agree that I can implement the separation of images in this PR; or accept the current situation, I will focus my energy on other matters.

@samzong samzong marked this pull request as ready for review November 20, 2025 09:20
@yuluo-yx
Copy link
Contributor

yuluo-yx commented Nov 20, 2025

emm~ I don't think it's necessary; it would only make submitting a PR more difficult. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rootfs rootfs Awaiting requested review from rootfs rootfs is a code owner

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo Xunzhuo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@rootfs rootfs

@Xunzhuo Xunzhuo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pre-commit docker image is tooooooo large

4 participants

@samzong @rootfs @yuluo-yx @Xunzhuo